[23.11] top-level: use callPackages where inheriting packages#297051
Merged
lilyinstarlight merged 1 commit intoNixOS:release-23.11from Mar 18, 2024
Merged
Conversation
otherwise those packages cannot be overriden Resubmition because of revert in NixOS#281932 (cherry picked from commit a276e8b)
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
lilyinstarlight
approved these changes
Mar 18, 2024
Member
|
Did you check if the internals of those packages are similar to unstable? If a package got refactored in the meantime, this could cause regressions and the initial PR had some oversights already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
(cherry picked from commit a276e8b)
This is, to me, a critical bugfix because some packages are expected to be overrideable...
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.