Merged
Conversation
ofborg
bot
requested review from
amaxine,
bobby285271,
dasj19,
hedning and
jtojnar
ofborg
bot
added
10.rebuild-darwin: 501+
amaxine
approved these changes
Mar 15, 2024
Contributor
|
Not sure how I missed the actual diff, but we landed 2.57.92 (i.e. beta for 2.58) and not 2.57.2 🤦♀️ |
Contributor
Author
|
Ugh, all my fault: I looked the version up on repology, but did not pay close attention to what updated script put into the file. |
Member
|
I checked the diff and missed it too 🤷♀️ Looking at the rest of the changes, they are fine too. The library no longer depends on gdk-pixbuf for loading images but I do not think it will allow us to do any cleanups as the loader is still build as a part of the package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: https://gitlab.gnome.org/GNOME/librsvg/-/releases/2.57.2
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.