postgresqlPackages: fixing multiple build failures#294457
Merged
fabianhjr merged 5 commits intoNixOS:masterfrom Mar 12, 2024
Merged
postgresqlPackages: fixing multiple build failures#294457fabianhjr merged 5 commits intoNixOS:masterfrom
fabianhjr merged 5 commits intoNixOS:masterfrom
Conversation
PostgreSQL older than v12 is not in nixpkgs anymore, so marking those as still broken in that case doesn't make sense anymore.
This failed because libxcrypt, which pg12 is linked against, was missing as a build input. In general, this is an indication that this extension needs the same build inputs that postgresql was built with - so we just pass those instead. This makes similar build failures less likely in the future.
This failed because libpam, which postgresql is now linked against, was missing as a build input. In general, this is an indication that this extension needs the same build inputs that postgresql was built with - so we just pass those instead. This makes similar build failures less likely in the future.
This failed because libpam, which postgresql is now linked against, was missing as a build input. In general, this is an indication that this extension needs the same build inputs that postgresql was built with - so we just pass those instead. This makes similar build failures less likely in the future.
https://github.com/plv8/plv8/blob/v3.1.10/Changes 3.1.10 is currently not the latest version - 3.2.2 is. However, the 3.2 branch needs more changes to build successfully. The update to 3.1.10 makes this package build with postgresql_16 for now.
ofborg
bot
added
10.rebuild-darwin: 11-100
13 tasks
delroth
added
12.approvals: 1
fabianhjr
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fixes multiple broken postgresqlPackages and removes some version checks for legacy postgresql versions, which are not part of nixpkgs anymore.
Extension maintainers: @marsam @zimbatm @danbst
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.