Skip to content

Comments

nixVersions.nix_2_20: init at 2.20.5#294120

Closed
Mic92 wants to merge 3 commits intoNixOS:masterfrom
Mic92:nix
Closed

nixVersions.nix_2_20: init at 2.20.5#294120
Mic92 wants to merge 3 commits intoNixOS:masterfrom
Mic92:nix

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 7, 2024

Description of changes

original PR: #285264

This is the squashed version.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92 Mic92 requested review from Ma27 and RaitoBezarius as code owners March 7, 2024 20:03
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 7, 2024
@ofborg ofborg bot requested review from Artturin, edolstra and lovesegfault March 7, 2024 20:33
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 7, 2024
@SuperSandro2000
Copy link
Member

I've updated the original PR. Not sure why you can't push, I have the box always ticked.

Comment on lines -19 to -25
# Major.minor versions unaffected by CVE-2024-27297
unaffectedByFodSandboxEscape = [
"2.3"
"2.18"
"2.19"
"2.20"
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this in the original PR, too? I am not sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because then you need to upgrade ALL the other Nix. Not just one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, then we leave it as it is in my PR. I just wasn't sure if I missed something or this was a bad rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants