Skip to content

treewide: Refactor packages to use darwin install binary package#293961

Draft
afh wants to merge 13 commits intoNixOS:masterfrom
afh:refactor-darwin-install-binary
Draft

treewide: Refactor packages to use darwin install binary package#293961
afh wants to merge 13 commits intoNixOS:masterfrom
afh:refactor-darwin-install-binary

Conversation

@afh
Copy link
Member

@afh afh commented Mar 7, 2024

Description of changes

ℹ️ This is a companion PR that builds upon #293498.
Because this PR targets master as the base branch the changes from #293498 as also included in this PR. Here's the diff to what changes to #293498.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 7, 2024
@afh afh changed the title Refactor packages to use darwin install binary package treewide: Refactor packages to use darwin install binary package Mar 7, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants