Skip to content

libredirect: don't test LFS64 functions on musl#292616

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
alyssais:libredirect-LFS64
Mar 2, 2024
Merged

libredirect: don't test LFS64 functions on musl#292616
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
alyssais:libredirect-LFS64

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Mar 1, 2024

Description of changes

These were removed in musl 1.2.4.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais alyssais added the 6.topic: musl Running or building packages with musl libc label Mar 1, 2024
@alyssais alyssais mentioned this pull request Mar 1, 2024
47 tasks
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 1, 2024
These were removed in musl 1.2.4.
@alyssais alyssais force-pushed the libredirect-LFS64 branch from 9490cf0 to 13eea13 Compare March 2, 2024 00:03
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 2, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 2, 2024
@SuperSandro2000 SuperSandro2000 merged commit 0c448ca into NixOS:staging Mar 2, 2024
@alyssais alyssais deleted the libredirect-LFS64 branch May 15, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: musl Running or building packages with musl libc 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants