Skip to content

libpsl: split outputs#292260

Merged
vcunat merged 1 commit intoNixOS:stagingfrom
vcunat:p/libpsl-outputs
Mar 12, 2024
Merged

libpsl: split outputs#292260
vcunat merged 1 commit intoNixOS:stagingfrom
vcunat:p/libpsl-outputs

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Feb 29, 2024

#285295 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vcunat vcunat added the 6.topic: closure size The final size of a derivation, including its dependencies label Feb 29, 2024
@vcunat
Copy link
Member Author

vcunat commented Feb 29, 2024

From reverse dependencies I've only checked curl really (builds, log looks OK, detecting libpsl).

@vcunat
Copy link
Member Author

vcunat commented Feb 29, 2024

The curl binary is quite a useful tool, so I do appreciate keeping its runtime closure small. This changes the du-reported size from 187 068 to 56 784 (KiB).

@ofborg ofborg bot requested review from c0bw3b and talyz February 29, 2024 07:48
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 29, 2024
@domenkozar
Copy link
Member

Let's merge?

@vcunat vcunat merged commit 43a630f into NixOS:staging Mar 12, 2024
@vcunat vcunat deleted the p/libpsl-outputs branch March 12, 2024 06:39
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/devenv-1-0-rewrite-in-rust/41891/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: closure size The final size of a derivation, including its dependencies 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants