lib tests: Add system parameter#291936
Merged
infinisil merged 1 commit intoNixOS:masterfrom Dec 17, 2024
Merged
Conversation
Member
|
See #291933 :) |
ofborg
bot
added
10.rebuild-darwin: 1-10
1 task
infinisil
requested changes
Feb 29, 2024
Member
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
The first commit is good, I'd drop the second one though.
lib/fileset/tests.sh
Outdated
Member
There was a problem hiding this comment.
Unfortunately this only seems to check the first line of the regex. It doesn't seem like grep supports that. So I think we should stick with the bash regex match for now.
roberth
force-pushed
the
fix-lib-tests-darwin
branch
from
5b1a7f8 to
0a4d338
Compare
ofborg
bot
added
10.rebuild-darwin: 0
infinisil
force-pushed
the
fix-lib-tests-darwin
branch
from
0a4d338 to
efd4a64
Compare
infinisil
approved these changes
Dec 17, 2024
Member
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
Rebased to fix the conflict, looking good :)
github-actions
bot
added
10.rebuild-darwin: 1-10
Member
Author
|
Thanks! |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-291936-to-release-24.11 origin/release-24.11
cd .worktree/backport-291936-to-release-24.11
git switch --create backport-291936-to-release-24.11
git cherry-pick -x efd4a649fe39a4156bf31af24028770e02c94fb5 |
Member
Author
|
Not convinced that a backport is necessary actually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Make it succeed on darwin.
I do not know why bash in darwin fails to match, but I have too much on my plate to also debug bash itself.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.