Skip to content

OVMF: Restore installation of OVMF.fd.#291565

Merged
K900 merged 1 commit intoNixOS:masterfrom
shlevy:ovmf-ms
Feb 26, 2024
Merged

OVMF: Restore installation of OVMF.fd.#291565
K900 merged 1 commit intoNixOS:masterfrom
shlevy:ovmf-ms

Conversation

@shlevy
Copy link
Member

@shlevy shlevy commented Feb 26, 2024

I accidentally removed this in f6fc51d (I missed the leading comma on line 160), which was merged as part of #284874

This should be removed eventually, but it should be done intentionally with proper release notes.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

I accidentally removed this in f6fc51d (I missed the leading comma on
line 160), which was merged as part of NixOS#284874

This should be removed eventually, but it should be done intentionally
with proper release notes.
@shlevy shlevy added the 1.severity: channel blocker Blocks a channel label Feb 26, 2024
@shlevy shlevy mentioned this pull request Feb 26, 2024
13 tasks
@shlevy shlevy requested a review from adamcstephens February 26, 2024 12:58
@K900
Copy link
Contributor

K900 commented Feb 26, 2024

@ofborg test boot.uefiCdrom

@K900 K900 merged commit 827c703 into NixOS:master Feb 26, 2024
@shlevy shlevy deleted the ovmf-ms branch February 26, 2024 13:13
@adamcstephens
Copy link
Contributor

Thanks for the quick fix @shlevy

@ofborg ofborg bot requested a review from RaitoBezarius February 26, 2024 13:22
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants