Skip to content

[staging-next] urlwatch: cherry-pick lxml 5 compatibility fix#291219

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
K900:urlwatch-lxml-next
Feb 24, 2024
Merged

[staging-next] urlwatch: cherry-pick lxml 5 compatibility fix#291219
vcunat merged 1 commit intoNixOS:staging-nextfrom
K900:urlwatch-lxml-next

Conversation

@K900
Copy link
Contributor

@K900 K900 commented Feb 24, 2024

Description of changes

Otherwise fails with AttributeError: 'CSSSelector' object has no attribute 'evaluate'.

Upstream commit direct link: thp/urlwatch@123de66

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from 4z3 and kmein February 24, 2024 20:03
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 24, 2024
@vcunat vcunat merged commit b9a08a7 into NixOS:staging-next Feb 24, 2024
@K900 K900 deleted the urlwatch-lxml-next branch July 27, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants