Skip to content

xz: 5.4.6 -> 5.6.0#291205

Merged
vcunat merged 1 commit intoNixOS:stagingfrom
trofi:xz-update
Feb 29, 2024
Merged

xz: 5.4.6 -> 5.6.0#291205
vcunat merged 1 commit intoNixOS:stagingfrom
trofi:xz-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Feb 24, 2024 •
edited
Loading

Changes: https://github.com/tukaani-project/xz/releases/tag/v5.6.0

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

IogaMaster
IogaMaster approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@IogaMaster IogaMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review has been done with warden, please report any issues!

Packages built

✅ xz

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 24, 2024
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Feb 24, 2024
@ofborg ofborg bot requested a review from svanderburg February 24, 2024 20:35
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 24, 2024
@vcunat
Copy link
Member

vcunat commented Feb 29, 2024

Notably:

  • Multithreaded mode is now the default.

@vcunat vcunat merged commit 7f1b4b7 into NixOS:staging Feb 29, 2024
@trofi trofi deleted the xz-update branch February 29, 2024 18:06
@mweinelt
Copy link
Member

mweinelt commented Mar 2, 2024

Bisect believes this regressed the tests of libbacktrace

5c7c19cc7ef416b2f4a154263c6d04a50bbac86c is the first bad commit
commit 5c7c19cc7ef416b2f4a154263c6d04a50bbac86c
Author: Sergei Trofimovich <[email protected]>
Date:   Sat Feb 24 18:15:35 2024 +0000

    xz: 5.4.6 -> 5.6.0
    
    Changes: https://github.com/tukaani-project/xz/releases/tag/v5.6.0

 pkgs/tools/compression/xz/default.nix | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

ianlancetaylor/libbacktrace#118

@mweinelt mweinelt mentioned this pull request Mar 2, 2024
Merged
1 task
@trofi
Copy link
Contributor Author

trofi commented Mar 2, 2024

Looking.

@trofi
Copy link
Contributor Author

trofi commented Mar 2, 2024

tukaani-project/xz@6daa4d0 xz: Use threaded mode by defaut (as if --threads=0 was used). upstream change caused the test failures in libbacktrace. Added the same comment to ianlancetaylor/libbacktrace#118 (comment)

Proposed libbacktrace workaround by forcing single-threaded mode as:

@Atry Atry mentioned this pull request Mar 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

1 more reviewer

@IogaMaster IogaMaster IogaMaster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trofi @vcunat @mweinelt @IogaMaster @delroth