Skip to content

python311Packages.autobahn: fix tests#290981

Merged
mweinelt merged 7 commits intoNixOS:staging-nextfrom
dotlambda:autobahn-fix
Feb 24, 2024
Merged

python311Packages.autobahn: fix tests#290981
mweinelt merged 7 commits intoNixOS:staging-nextfrom
dotlambda:autobahn-fix

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 23, 2024

Description of changes

cc #289734

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

With version 0.23 the tests fail with

    RuntimeError: Event loop is closed
@dotlambda dotlambda requested a review from mweinelt February 23, 2024 21:15
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 23, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 23, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 23, 2024
@mweinelt
Copy link
Member

Fails on 3.12 due to spake build failure, if you want to tackle that as well.

@dotlambda dotlambda marked this pull request as draft February 23, 2024 23:26
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Feb 23, 2024
@dotlambda dotlambda marked this pull request as ready for review February 23, 2024 23:47
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 24, 2024
@mweinelt mweinelt merged commit 5faa932 into NixOS:staging-next Feb 24, 2024
@dotlambda dotlambda deleted the autobahn-fix branch February 24, 2024 00:56
@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants