Skip to content

Revert "python312Packages.pbr: mark as broken"#290884

Merged
mweinelt merged 1 commit intoNixOS:stagingfrom
mweinelt:pbr-unbreak
Feb 23, 2024
Merged

Revert "python312Packages.pbr: mark as broken"#290884
mweinelt merged 1 commit intoNixOS:stagingfrom
mweinelt:pbr-unbreak

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Feb 23, 2024

This reverts commit 29b2ca9.

Apparently not as broken was we thought. While holding distutils code paths, it does not always call into them.

Description of changes

Finding out how much rebuilds this causes.

Estimating rebuild amount by counting changed Hydra jobs (parallel=unset).
   2753 x86_64-darwin
   2121 x86_64-linux

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 23, 2024
@mweinelt mweinelt changed the base branch from master to staging February 23, 2024 13:04
This reverts commit 29b2ca9.

Apparently not as broken was we thought. While holding distutils code
paths, it does not always call into them.
@mweinelt mweinelt marked this pull request as ready for review February 23, 2024 13:05
@mweinelt mweinelt merged commit e633932 into NixOS:staging Feb 23, 2024
@mweinelt mweinelt deleted the pbr-unbreak branch February 23, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant