Skip to content

Comments

lib/tests/test-with-nix.nix: init entrypoint for NixOS/nix CI#290831

Merged
infinisil merged 1 commit intoNixOS:masterfrom
hercules-ci:lib-tests-entrypoint
Feb 26, 2024
Merged

lib/tests/test-with-nix.nix: init entrypoint for NixOS/nix CI#290831
infinisil merged 1 commit intoNixOS:masterfrom
hercules-ci:lib-tests-entrypoint

Conversation

@roberth
Copy link
Member

@roberth roberth commented Feb 23, 2024

Description of changes

Provide a file that the nix CI can import. This helps ascertain the release worthiness of Nix itself during its development.
It previously used the following, but that broke somewhat recently.

              import (nixpkgs + "/lib/tests/release.nix")
                { inherit pkgs;
                  nixVersions = [ nix ];
                }

This is intended to be used on the Nix side in

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@roberth roberth force-pushed the lib-tests-entrypoint branch from 9a668a5 to 475ee3a Compare February 23, 2024 10:07
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 23, 2024
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@infinisil infinisil merged commit 8e4f5e9 into NixOS:master Feb 26, 2024
@infinisil infinisil mentioned this pull request Feb 26, 2024
13 tasks
roberth added a commit to hercules-ci/nix that referenced this pull request Feb 27, 2024
This contains NixOS/nixpkgs#290831

Flake lock file updates:

• Updated input 'nixpkgs':
    'github:hercules-ci/nixpkgs/181e3f88238f9b158985e13ac84569a42648834e' (2024-02-01)
  → 'github:NixOS/nixpkgs/548a86b335d7ecd8b57ec617781f5e652ab0c38e' (2024-02-26)
roberth added a commit to hercules-ci/nix that referenced this pull request Feb 27, 2024
This contains NixOS/nixpkgs#290831

Flake lock file updates:

• Updated input 'nixpkgs':
    'github:hercules-ci/nixpkgs/181e3f88238f9b158985e13ac84569a42648834e' (2024-02-01)
  → 'github:NixOS/nixpkgs/548a86b335d7ecd8b57ec617781f5e652ab0c38e' (2024-02-26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants