Skip to content

Comments

boolector: 3.2.2 -> 3.2.3 + upstream patch for C++14 compatibility.#290693

Merged
lukegb merged 1 commit intoNixOS:staging-nextfrom
simonhollingshead:boolector-3.2.3-plus-cpp14
Feb 23, 2024
Merged

boolector: 3.2.2 -> 3.2.3 + upstream patch for C++14 compatibility.#290693
lukegb merged 1 commit intoNixOS:staging-nextfrom
simonhollingshead:boolector-3.2.3-plus-cpp14

Conversation

@simonhollingshead
Copy link
Member

@simonhollingshead simonhollingshead commented Feb 22, 2024 •
edited
Loading

Description of changes

Boolector/boolector@3.2.2...3.2.3 Boolector/boolector@cc13f37

This bumps the version but also brings in a fix not yet in the release for a breakage caused by #282245.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vcunat vcunat mentioned this pull request Feb 22, 2024
Merged
13 tasks
@simonhollingshead simonhollingshead marked this pull request as ready for review February 22, 2024 20:03
@ofborg ofborg bot requested a review from thoughtpolice February 22, 2024 20:15
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 22, 2024
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 23, 2024
@lukegb lukegb merged commit ed88887 into NixOS:staging-next Feb 23, 2024
@simonhollingshead simonhollingshead deleted the boolector-3.2.3-plus-cpp14 branch March 2, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simonhollingshead @thoughtpolice @delroth @lukegb