Skip to content

zrythm: 1.0.0-beta.4.9.1 -> 1.0.0-beta.6.4.1#290598

Closed
PowerUser64 wants to merge 1 commit intoNixOS:masterfrom
PowerUser64:zrythm-6.3-b
Closed

zrythm: 1.0.0-beta.4.9.1 -> 1.0.0-beta.6.4.1#290598
PowerUser64 wants to merge 1 commit intoNixOS:masterfrom
PowerUser64:zrythm-6.3-b

Conversation

@PowerUser64
Copy link
Member

@PowerUser64 PowerUser64 commented Feb 22, 2024

Description of changes

Update zrythm to v1.0.0-beta.6.4.1. Please note that I am using overrideAttrs in two places because nixpkgs' gtk and rtaudio are not on new enough versions for zrythm to compile. I was told that using overrideAttrs in buildInputs should be allowed here, but please let me know if this is not true.

Closes #252561
Closes #253765

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 22, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 22, 2024
@ofborg ofborg bot requested review from magnetophon and tshaynik February 22, 2024 09:38
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 22, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/100

@contini-aron
Copy link

contini-aron commented Mar 27, 2024

@PowerUser64 i was trying to build from source in the meantime this PR is reviewed and got an hash error mismatch

steps to reproduce

 nix build github:PowerUser64/nixpkgs/zrythm-6.3-b#zrythm

error

error: hash mismatch in fixed-output derivation '/nix/store/hckfhayyh20p35qhb772dmgsb854bwqz-source.drv':
         specified: sha256-OjUZzU5mqsM+8HkUvSD7E3WPiO+X9uzDwQA4rheJXTg=
            got:    sha256-veRzcxLGP8jkm0qWK98aSfEMv/UFPkgPOT/yRI8jfdc=

the specified hash seems to be the one for gitlab zrythm in this code block

  src = fetchFromGitLab {
    domain = "gitlab.zrythm.org";
    owner = "zrythm";
    repo = "zrythm";
    rev = "v${finalAttrs.version}";
    hash = "sha256-OjUZzU5mqsM+8HkUvSD7E3WPiO+X9uzDwQA4rheJXTg=";
  };

hope this helps

@Aleksanaa
Copy link
Member

Don't override it. Just wait for #291339

@eclairevoyant
Copy link
Contributor

FYI zrythm seems to be a troublesome program that always uses unreleased gtk/libadwaita versions, so we can never upgrade immediately without overriding

@Aleksanaa
Copy link
Member

FYI zrythm seems to be a troublesome program that always uses unreleased gtk/libadwaita versions, so we can never upgrade immediately without overriding

The flatpak guys, yeah

@PowerUser64
Copy link
Member Author

Zrythm is still in beta, so I'm thinking it might be easier to maintain a package once it gets its first stable release. I could be wrong though.

@eclairevoyant
Copy link
Contributor

It's been in alpha for a year and in beta for 2 years more, I'm not sure when a stable release would materialise.

@PowerUser64
Copy link
Member Author

The release should be soon, hopefully in the next few months. There are only 9 issues left on the v1.rc milestone according to the zrythm gitlab. Developing a DAW solo takes a lot of time I guess.

cc @alex-tee

@alex-tee
Copy link
Contributor

alex-tee commented Apr 2, 2024

Yes v1 RC should be out soon. I don't plan to use any unreleased libadwaita/gtk API anymore for v1 so the latest stable releases should be OK.

Just a nitpick: can you please fetch the source tarball from https://www.zrythm.org/releases/ instead of gitlab? Our Gitlab instance is really only meant to be used for development, not distribution. I want to avoid unnecessary traffic to it.

Also FYI json-glib and libaudec are no longer used so they can be removed from the dependencies.

@PowerUser64
Copy link
Member Author

PowerUser64 commented Apr 2, 2024

Thanks for the response and feedback @alex-tee! I'll adjust the source to retrieve from zrythm.org, and remove the old deps! Can't wait for v1!

@PowerUser64 PowerUser64 marked this pull request as draft April 2, 2024 19:30
@nyabinary nyabinary mentioned this pull request Apr 3, 2024
27 tasks
@PowerUser64
Copy link
Member Author

Superseded by #306959 (Merged)

@PowerUser64 PowerUser64 closed this May 2, 2024
@PowerUser64 PowerUser64 deleted the zrythm-6.3-b branch May 2, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update request: zrythm 1.0.0-beta.4.9.1 → 1.0.0-beta.4.12.34

6 participants