Skip to content

nixos/etc: make re-mounting /etc overlay idempotent#290490

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
nikstur:idempotent-etc-activation
Feb 22, 2024
Merged

nixos/etc: make re-mounting /etc overlay idempotent#290490
Mic92 merged 1 commit intoNixOS:masterfrom
nikstur:idempotent-etc-activation

Conversation

@nikstur
Copy link
Contributor

@nikstur nikstur commented Feb 21, 2024

Fixes #287261

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nikstur nikstur requested a review from dasJ as a code owner February 21, 2024 21:57
@nikstur nikstur requested a review from Mic92 February 21, 2024 21:57
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 21, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 21, 2024
@nikstur
Copy link
Contributor Author

nikstur commented Feb 21, 2024

@ofborg test activation-etc-overlay-immutable activation-etc-overlay-mutable

@Mic92
Copy link
Member

Mic92 commented Feb 22, 2024

Tested and works

@Mic92 Mic92 merged commit 87f6f1f into NixOS:master Feb 22, 2024
@nikstur nikstur deleted the idempotent-etc-activation branch February 22, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

system.etc.overlay.enable crashes systemd when doing switch-to-configuration test

2 participants