rapidjson: build with C++17 language level#290250
Merged
SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom Feb 20, 2024
Merged
rapidjson: build with C++17 language level#290250SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom
SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom
Conversation
gtest was upgraded to 1.14.0; as of 1.13.x gtest requires at least c++14 to build. rapidjson's CMake scripts have support for specifying C++11 or C++17; rather than add our own support for C++14 we set the C++17 flag instead.
ofborg
bot
added
10.rebuild-darwin: 101-500
13 tasks
Member
|
@ofborg build python3.pkgs.python-rapidjson |
dotlambda
approved these changes
Feb 20, 2024
delroth
added
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
gtest was upgraded to 1.14.0; as of 1.13.x gtest requires at least c++14 to build.
rapidjson's CMake scripts have support for specifying C++11 or C++17; rather than add our own support for C++14 we set the C++17 flag instead.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.