pkgsi686Linux.samba: don't configure waf in parallel on 32-bit systems#289405
Merged
fabianhjr merged 1 commit intoNixOS:masterfrom Feb 17, 2024
Merged
pkgsi686Linux.samba: don't configure waf in parallel on 32-bit systems#289405fabianhjr merged 1 commit intoNixOS:masterfrom
waf in parallel on 32-bit systems#289405fabianhjr merged 1 commit intoNixOS:masterfrom
Conversation
Without the change `waf configure` hung on `i686Linux.samba` on systems
with large amount of host CPUs (for me it's 16).
This happens because one of the worker processes gets `-ENOMEM` and does
not recover from it:
2084476 mmap2(NULL, 8392704, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_STACK, -1, 0) = -1 ENOMEM (Cannot allocate memory)
2084476 munmap(0xf2b5c000, 16384) = 0
2084476 rt_sigprocmask(SIG_BLOCK, ~[RT_1], NULL, 8) = 0
2084476 madvise(0x1ff000, 8372224, MADV_DONTNEED) = 0
2084476 exit(0) = ?
2084476 +++ exited with 0 +++
THe change extends 32-bit arm workaround to limit to one thread to all
32-bit systems.
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Without the change
waf configurehung oni686Linux.sambaon systems with large amount of host CPUs (for me it's 16).This happens because one of the worker processes gets
-ENOMEMand does not recover from it:THe change extends 32-bit arm workaround to limit to one thread to all 32-bit systems.
Closes #287339
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.