Skip to content

alsa-ucm-conf: drop conflicting upstream patch#289388

Merged
adamcstephens merged 1 commit intoNixOS:stagingfrom
trofi:alsa-ucm-conf-patch-drop
Feb 17, 2024
Merged

alsa-ucm-conf: drop conflicting upstream patch#289388
adamcstephens merged 1 commit intoNixOS:stagingfrom
trofi:alsa-ucm-conf-patch-drop

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Feb 16, 2024

Without the change the build fails on staging as:

alsa-ucm-conf> Running phase: patchPhase
alsa-ucm-conf> applying patch /nix/store/m1yxcbpkxrqjp7kml9ij2x4i1y5zc0m2-alsa-ucm-conf-splitpcm-device-argument-fix.patch
alsa-ucm-conf> patching file ucm2/common/pcm/split.conf
alsa-ucm-conf> Reversed (or previously applied) patch detected!  Assume -R? [n]
alsa-ucm-conf> Apply anyway? [n]
alsa-ucm-conf> Skipping patch.
alsa-ucm-conf> 1 out of 1 hunk ignored -- saving rejects to file ucm2/common/pcm/split.conf.rej

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Without the change the build fails on `staging` as:

    alsa-ucm-conf> Running phase: patchPhase
    alsa-ucm-conf> applying patch /nix/store/m1yxcbpkxrqjp7kml9ij2x4i1y5zc0m2-alsa-ucm-conf-splitpcm-device-argument-fix.patch
    alsa-ucm-conf> patching file ucm2/common/pcm/split.conf
    alsa-ucm-conf> Reversed (or previously applied) patch detected!  Assume -R? [n]
    alsa-ucm-conf> Apply anyway? [n]
    alsa-ucm-conf> Skipping patch.
    alsa-ucm-conf> 1 out of 1 hunk ignored -- saving rejects to file ucm2/common/pcm/split.conf.rej
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 16, 2024
@ofborg ofborg bot requested a review from roastiek February 16, 2024 22:47
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 16, 2024
@philiptaron philiptaron mentioned this pull request Feb 17, 2024
13 tasks
@adamcstephens adamcstephens merged commit 872e575 into NixOS:staging Feb 17, 2024
@trofi trofi deleted the alsa-ucm-conf-patch-drop branch February 17, 2024 09:29
@github-actions
Copy link
Contributor

Successfully created backport PR for staging-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants