[Backport staging-next-23.11] OVMF: fix buils against openssl-3.0.13#289298
Merged
vcunat merged 1 commit intostaging-next-23.11from Feb 16, 2024
Merged
[Backport staging-next-23.11] OVMF: fix buils against openssl-3.0.13#289298vcunat merged 1 commit intostaging-next-23.11from
openssl-3.0.13#289298vcunat merged 1 commit intostaging-next-23.11from
Conversation
Without the change the build fails on `staging-next` as https://hydra.nixos.org/build/248863953/nixlog/2/tail: /build/edk2-unvendored-src/CryptoPkg/Library/OpensslLib/openssl/crypto/property/property_parse.c:107:19: error: ‘INT64_MAX’ undeclared (first use in this function) 107 | if (v > ((INT64_MAX - (*s - '0')) / 10)) { | ^~~~~~~~~ The unbundled version of `openssl` `nixpkgs` injects into `edk2` started using `INT64_MAX` that `edk2`'s `<stdint.h>` does not provide and relies on `openssl` to define as a fallback. Let's pull in `openssl`'s own definition of those. (cherry picked from commit 7b01dd0)
13 tasks
vcunat
requested review from
Ma27,
RaitoBezarius,
aanderse,
drupol,
etu,
globin and
talyz
as code owners
vcunat
changed the title
openssl-3.0.13openssl-3.0.13
Member
|
This accidental ping was actually good because I was initially wondering last night why OVMF was breaking on the glibc update branch, but apparently I've compared against an eval that's too new 😅 |
ofborg
bot
added
10.rebuild-darwin: 1-10
vcunat
removed request for
LunNova,
Ma27,
aanderse,
adamcstephens and
globin
Member
|
Oh, I'm sorry about the pings. I didn't even notice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-23.11, triggered by a label in #287266.