nv-codec-headers: adopt and refactor#287918
Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom Feb 23, 2024
atorres1985-contrib:nv-codec-headers
Merged
nv-codec-headers: adopt and refactor#287918SuperSandro2000 merged 1 commit intoNixOS:stagingfrom atorres1985-contrib:nv-codec-headers
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
atorres1985-contrib:nv-codec-headers
Conversation
13 tasks
ofborg
bot
added
8.has: package (new)
Member
Author
|
@infinisil it looks like a bug to me! Can you verify? I am using an external file to parameterize the |
Member
|
Not a bug I'm afraid! To CI, the Since inherit (callPackages ../development/libraries/nv-codec-headers { })
nv-codec-headers-9 nv-codec-headers-10;or if you want to also expose the set of versions: nv-codec-headers-versions = callPackages ../development/libraries/nv-codec-headers { };
inherit (nv-codec-headers-versions)
nv-codec-headers-9 nv-codec-headers-10;See also #285922 (comment) or #287081 for some discussion on this. |
Member
Author
|
|
ofborg
bot
requested review from
Anton-Latukha,
WilliButz,
anthonyroussel,
cpages,
gbtb and
wmertens
13 tasks
19 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
pkgs/development/libraries/nv-codec-headers/make-nv-codec-headers.nix
Outdated
Show resolved
Hide resolved
It globs all versions of nv-codec-headers kept/needed on Nixpkgs. The default is kept at 9, as before.
Sigmanificient
added
the
0.kind: package adoption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.