I am not sure how to make the by-name check happy given multiple versions living in teleport/14 teleport/15 etc.

The pkgs/by-name only requires new packages to use it, and that is based on whether the new definition looks like <attr> = callPackage ..., which is the case here.

Since there's a generic.nix file used by all the versions, you're a bit more restricted in what you can do, but there's some options:

• My recommendation: Avoid pkgs/by-name for now by creating a package set for all versions, either like this:

    teleportVersions = callPackages ../servers/teleport { };
    inherit (teleportVersions) teleport_14 teleport_15 teleport;

  Or if you don't want to expose teleportVersions to users:

    inherit (callPackages ../servers/teleport { })
      teleport_14 teleport_15 teleport;

  • There's a bug in the pkgs/by-name check that would still complain about this, see tests.nixpkgs-check-by-name: Syntactic callPackage detection and allow new package variants #285089, but this would be allowed

    Now fixed!

• Alternatively, expose generic.nix as pkgs.teleportGeneric, such that you can refactor the individual versions to use pkgs/by-name, each of which taking teleportGeneric as an argument:

  { teleportGeneric }:
  teleportGeneric { ... }

Thanks for the advice @infinisil , I ended up utilizing callPackages and the check passes now.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3614

Can you rebase? otherwise LGTM

Rebased.

Result of nixpkgs-review pr 285922 run on x86_64-linux 1