bazel: 7.0.0 -> 7.0.2#285544
Conversation
ofborg
Bot
added
10.rebuild-darwin: 1-10
flurie
left a comment
flurie
left a comment
There was a problem hiding this comment.
I ran nixpkgs-review and tested the Bazel binary on a few targets in large Bazel 7 project on x86_64-linux. I did not test the hermetic /tmp fix specifically, but I have had some users verify that 7.0.2 fixes the issue for them, so I am satisfied.
I can also run nixpkgs-review on aarch64-darwin, but I'm not sure how functional this is on darwin in general? The meta info indicates it is.
|
Do you think it makes sense to add this patch back? https://github.com/sourcegraph/sourcegraph/pull/59359 I also ran into it for multiple Bazel projects. |
I would be tempted to put in a separate PR, although theres some unfinished discussion on the topic here: #262152 |
4 participants
Description of changes
Changelog for 7.0.2: https://github.com/bazelbuild/bazel/releases/tag/7.0.2
List of commits between 7.0.0 and 7.0.2: bazelbuild/bazel@7.0.0...7.0.2
Most importantly perhaps, this bump fixes bazelbuild/bazel#20527.
This PR also includes provisions to enable overriding the version. Previously this wasnt trivial to do due to
versionbeing a locally scoped variable, so while thesrccould be updated,versionwas used in a few attributes via string interpolation that are more awkward to patch than it could beThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.