nixVersions.nix_2_20: init at 2.20.5; nixVersions.unstable: 2.19 -> 2.20 by SuperSandro2000 · Pull Request #285264 · NixOS/nixpkgs

SuperSandro2000 · 2024-01-31T12:44:13Z

Description of changes

nix> In file included from include/boost/container/vector.hpp:27,
nix>                  from include/boost/container/small_vector.hpp:27,
nix>                  from src/libexpr/gc-small-vector.hh:3,
nix>                  from src/libexpr/eval.cc:21:
nix> include/boost/container/allocator_traits.hpp: In instantiation of 'struct boost::container::allocator_traits<traceable_allocator<void> >':
nix> include/boost/container/small_vector.hpp:122:7:   required from 'class boost::container::small_vector_allocator<nix::Value*, traceable_allocator<void>, void>'
nix> include/boost/container/allocator_traits.hpp:145:48:   required from 'struct boost::container::allocator_traits<boost::container::small_vector_allocator<nix::Value*, traceable_allocator<void>, void> >'
nix> include/boost/container/vector.hpp:802:88:   required from 'class boost::container::vector<nix::Value*, boost::container::small_vector_allocator<nix::Value*, traceable_allocator<void>,
void>, void>'
nix> include/boost/container/small_vector.hpp:341:7:   required from 'class boost::container::small_vector_base<nix::Value*, traceable_allocator<nix::Value*>, void>'
nix> include/boost/container/small_vector.hpp:531:7:   required from 'class boost::container::small_vector<nix::Value*, 4, traceable_allocator<nix::Value*>, void>'
nix> src/libexpr/eval.cc:1730:31:   required from here
nix> include/boost/container/allocator_traits.hpp:145:48: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> In file included from src/libexpr/value.hh:15,
nix>                  from src/libexpr/nixexpr.hh:7,
nix>                  from src/libexpr/attr-set.hh:4,
nix>                  from src/libexpr/eval.hh:4,
nix>                  from src/libexpr/eval.cc:1:
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:210:13: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:215:16: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:215:16: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:219:13: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:223:16: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:228:16: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:233:16: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> In file included from include/boost/container/vector.hpp:27,
nix>                  from include/boost/container/small_vector.hpp:27,
nix>                  from src/libexpr/gc-small-vector.hh:3,
nix>                  from src/libexpr/primops.cc:7:
nix> include/boost/container/allocator_traits.hpp: In instantiation of 'struct boost::container::allocator_traits<traceable_allocator<void> >':
nix> include/boost/container/small_vector.hpp:122:7:   required from 'class boost::container::small_vector_allocator<nix::Value*, traceable_allocator<void>, void>'
nix> include/boost/container/allocator_traits.hpp:145:48:   required from 'struct boost::container::allocator_traits<boost::container::small_vector_allocator<nix::Value*, traceable_allocator<void>, void> >'
nix> include/boost/container/vector.hpp:802:88:   required from 'class boost::container::vector<nix::Value*, boost::container::small_vector_allocator<nix::Value*, traceable_allocator<void>,
void>, void>'
nix> include/boost/container/small_vector.hpp:341:7:   required from 'class boost::container::small_vector_base<nix::Value*, traceable_allocator<nix::Value*>, void>'
nix> include/boost/container/small_vector.hpp:531:7:   required from 'class boost::container::small_vector<nix::Value*, 128, traceable_allocator<nix::Value*>, void>'
nix> src/libexpr/primops.cc:2733:56:   required from here
nix> include/boost/container/allocator_traits.hpp:145:48: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> In file included from src/libexpr/value.hh:15,
nix>                  from src/libexpr/nixexpr.hh:7,
nix>                  from src/libexpr/attr-set.hh:4,
nix>                  from src/libexpr/eval.hh:4,
nix>                  from src/libexpr/eval-inline.hh:5,
nix>                  from src/libexpr/primops.cc:4:
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:210:13: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:215:16: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:215:16: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:219:13: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:223:16: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:228:16: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> include/boost/container/allocator_traits.hpp:233:16: error: 'typedef void traceable_allocator<void>::value_type' is private within this context
nix> /nix/store/7ikfgkswxfcqcxhpcz3bcpg98hv523y4-boehm-gc-8.2.4-dev/include/gc/gc_allocator.h:319:23: note: declared private here
nix>   319 |   typedef void        value_type;
nix>       |                       ^~~~~~~~~~
nix> make: *** [mk/patterns.mk:2: src/libexpr/eval.o] Error 1
nix> make: *** Waiting for unfinished jobs....
nix> make: *** [mk/patterns.mk:2: src/libexpr/primops.o] Error 1
nix> rm src/nix/generated-doc/files/profiles.md

Things done

Add a 👍 reaction to pull requests you find important.

edolstra · 2024-02-01T12:02:57Z

boehm-gc in nixpkgs requires this patch: https://github.com/NixOS/nix/blob/master/dep-patches/boehmgc-traceable_allocator-public.diff

roberth · 2024-02-01T14:19:14Z

I've added the patch before the other commits. It's not specific to Nix, and is always valid.
In this order all commits should be buildable.

nixos-discourse · 2024-02-02T11:04:35Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-2-20-released/39027/6

infinisil · 2024-02-03T22:18:02Z

Btw the lib test failure is legit, it detected a regression: NixOS/nix#9901

Update nix-doc to be API compatible with Nix 2.20 when that is released. cc #285264

nyabinary · 2024-02-09T17:41:53Z

What work does this need to be ready?

infinisil · 2024-02-10T02:05:24Z

@nyabinary Nixpkgs CI runs the lib tests for all nixVersions, so the regression in 2.20 should be fixed first.

SuperSandro2000 · 2024-02-16T21:03:40Z

we are waiting for NixOS/nix#10023 to be included in a tag

edolstra · 2024-02-19T14:37:43Z

2.20.2 is now released.

infinisil · 2024-02-19T19:13:06Z

I'm both glad and sad to see that the lib.fileset tests discovered more regressions..

Ma27 · 2024-02-19T21:48:07Z

Personally, I'm not convinced that we should provide a Nix that's not compatible with our lib.

SuperSandro2000 · 2024-02-20T09:58:07Z

Maybe nix should run those tests, so that in the future those regressions are not only noticed after a release and the bump in nixpkgs.

infinisil · 2024-02-20T10:14:03Z

@SuperSandro2000 Agreed, there's even already a draft PR by Robert for that: NixOS/nix#9900

RaitoBezarius

I don't like repeating myself: this has to wait for a patch release from Nix upstream. People wanting the ultimate bleeding edge can apply this PR as a patch themselves. There's no need to rush the unstable package.

For the stable package, this is out of the question given the current regression atmosphere.

Ma27 · 2024-03-03T15:28:33Z

@RaitoBezarius For which patch specifically? edcb3430ef39a225aada06ef898c907d8277fbe8 and the stuff before that @roberth has added (and also appears to pass CI)?
That's part of 2.20.4: https://github.com/NixOS/nix/commits/2.20.4/
Sorry, wrote 2.20.5 first because I misread the commit log.

RaitoBezarius · 2024-03-03T15:32:31Z

@RaitoBezarius For which patch specifically? edcb3430ef39a225aada06ef898c907d8277fbe8 and the stuff before that @roberth has added (and also appears to pass CI)? That's part of 2.20.4: NixOS/nix@2.20.4 (commits) Sorry, wrote 2.20.5 first because I misread the commit log.

Yeah,

It seems recent, as long as this PR is bumped to this patch release and tests passes, we can proceed.

SuperSandro2000 · 2024-03-03T23:48:15Z

I assume you're strictly talking about the applied patch and not about the fact that lib tests were broken before?

I was referring to #285264 (comment)

However, I'm against declaring it stable just in case people are considering to do so now.

Not part of this PR anyway and I can delegate that decision to other people.

It seems recent, as long as this PR is bumped to this patch release and tests passes, we can proceed.

That somehow went passed me. Updated now.

Ma27 · 2024-03-04T06:12:03Z

Not part of this PR anyway and I can delegate that decision to other people.

Sure, that was statement was made proactively just in case people were about to reconsider this decision :)

pkgs/tools/package-management/nix/default.nix

Mic92 · 2024-03-07T20:04:38Z

I couldn't force push to squash the existing commits while fixing merge conflicts, so I created a new PR: #294120

Changelog: https://github.com/NixOS/nix/blob/2.20.5/doc/manual/src/release-notes/rl-2.20.md

SuperSandro2000 · 2024-03-08T10:28:00Z

So, who wants to press the merge button?

marcusramberg · 2024-03-08T12:35:20Z

I guess the pr title should be updated to say 2.20.5.

Stale

domenkozar · 2024-03-22T06:41:07Z

Should this be backported to 23.11?

RaitoBezarius · 2024-03-22T13:36:23Z

Usually, we don't aim to backport nixVersions.unstable bump to stable.

Because unstable's Nix in stable should be stable and too many people depend on unstable Nix thinking it's stable in general when it's not.

I have no strong feeling, but I'm not keeping the pieces if it breaks someone's production.

Mic92 · 2024-03-22T14:24:11Z

What if the it's just a new attribute 2_20, 2_21 but leaving nixVersions.unstable untouched?

RaitoBezarius · 2024-03-22T14:28:21Z

What if the it's just a new attribute 2_20, 2_21 but leaving nixVersions.unstable untouched?

Completely fine, per backport policies!

SuperSandro2000 mentioned this pull request Jan 31, 2024

2.20.1 fails to compile with private declared function in boost NixOS/nix#9888

Closed

roberth force-pushed the nix-1.20 branch from 7c51eb3 to 55d3673 Compare February 1, 2024 14:18

roberth mentioned this pull request Feb 1, 2024

~Add nixos-unstable based outputs, bdwgc 8.2.4~, Nixpkgs lib tests, cleanup NixOS/nix#9900

Draft

3 tasks

infinisil mentioned this pull request Feb 1, 2024

builtins.pathExists returns false on symlinks that point to non-existent paths NixOS/nix#9901

Closed

SuperSandro2000 marked this pull request as ready for review February 3, 2024 20:09

SuperSandro2000 requested a review from RaitoBezarius as a code owner February 3, 2024 20:09

lf- mentioned this pull request Feb 4, 2024

nix-doc: 0.6.4 -> 0.6.5 #286218

Merged

13 tasks

kirillrdy pushed a commit that referenced this pull request Feb 5, 2024

nix-doc: 0.6.4 -> 0.6.5

3c5e441

Update nix-doc to be API compatible with Nix 2.20 when that is released. cc #285264

SuperSandro2000 requested a review from Ma27 as a code owner February 19, 2024 14:27

SuperSandro2000 force-pushed the nix-1.20 branch from 6c7a593 to 45e73d0 Compare February 19, 2024 15:22

roberth approved these changes Feb 19, 2024

View reviewed changes

teutat3s approved these changes Feb 19, 2024

View reviewed changes

infinisil mentioned this pull request Feb 19, 2024

fetchGit regression in read-only mode NixOS/nix#10040

Closed

RaitoBezarius previously requested changes Mar 3, 2024

View reviewed changes

SuperSandro2000 force-pushed the nix-1.20 branch from 42c5c2b to 4c66b45 Compare March 3, 2024 23:48

roberth approved these changes Mar 6, 2024

View reviewed changes

teutat3s requested a review from RaitoBezarius March 6, 2024 16:18

Ma27 reviewed Mar 7, 2024

View reviewed changes

pkgs/tools/package-management/nix/default.nix Outdated Show resolved Hide resolved

Mic92 mentioned this pull request Mar 7, 2024

nixVersions.nix_2_20: init at 2.20.5 #294120

Closed

13 tasks

ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 7, 2024

SuperSandro2000 force-pushed the nix-1.20 branch from 8742e49 to bd698b3 Compare March 7, 2024 21:18

roberth and others added 3 commits March 7, 2024 22:26

nix/boehmgc-nix: add patch for nix 2.20

d104693

nixVersions.nix_2_20: init at 2.20.5

cbb540e

Changelog: https://github.com/NixOS/nix/blob/2.20.5/doc/manual/src/release-notes/rl-2.20.md

nixVersions.unstable: 2.19 -> 2.20

9080c36

SuperSandro2000 force-pushed the nix-1.20 branch from bd698b3 to 9080c36 Compare March 7, 2024 21:28

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 7, 2024

ofborg bot requested a review from Ma27 March 7, 2024 21:58

lovesegfault merged commit 3ce7157 into NixOS:master Mar 8, 2024

SuperSandro2000 changed the title ~~nixVersions.nix_2_20: init at 2.20.3; nixVersions.unstable: 2.19 -> 2.20~~ nixVersions.nix_2_20: init at 2.20.5; nixVersions.unstable: 2.19 -> 2.20 Mar 8, 2024

SuperSandro2000 deleted the nix-1.20 branch March 8, 2024 14:59

Uh oh!

Comments

Conversation

SuperSandro2000 commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

edolstra commented Feb 1, 2024

Uh oh!

roberth commented Feb 1, 2024

Uh oh!

nixos-discourse commented Feb 2, 2024

Uh oh!

infinisil commented Feb 3, 2024

Uh oh!

nyabinary commented Feb 9, 2024

Uh oh!

infinisil commented Feb 10, 2024

Uh oh!

SuperSandro2000 commented Feb 16, 2024

Uh oh!

edolstra commented Feb 19, 2024

Uh oh!

infinisil commented Feb 19, 2024

Uh oh!

Ma27 commented Feb 19, 2024

Uh oh!

SuperSandro2000 commented Feb 20, 2024

Uh oh!

infinisil commented Feb 20, 2024

Uh oh!

RaitoBezarius left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ma27 commented Mar 3, 2024

Uh oh!

RaitoBezarius commented Mar 3, 2024

Uh oh!

SuperSandro2000 commented Mar 3, 2024

Uh oh!

Ma27 commented Mar 4, 2024

Uh oh!

Uh oh!

Mic92 commented Mar 7, 2024

Uh oh!

SuperSandro2000 commented Mar 8, 2024

Uh oh!

marcusramberg commented Mar 8, 2024

Uh oh!

domenkozar commented Mar 22, 2024

Uh oh!

RaitoBezarius commented Mar 22, 2024

Uh oh!

Mic92 commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RaitoBezarius commented Mar 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

SuperSandro2000 commented Jan 31, 2024 •

edited

Loading

RaitoBezarius left a comment •

edited

Loading

Mic92 commented Mar 22, 2024 •

edited

Loading