qgnomeplatform: 0.8.4 -> 0.9.2; nixos/qt: do not require qt.style#285018
Draft
amarshall wants to merge 2 commits intoNixOS:masterfrom
Draft
qgnomeplatform: 0.8.4 -> 0.9.2; nixos/qt: do not require qt.style#285018amarshall wants to merge 2 commits intoNixOS:masterfrom
amarshall wants to merge 2 commits intoNixOS:masterfrom
Conversation
9cc34f7 to
47fde40
Compare
47fde40 to
8b32df7
Compare
8b32df7 to
7f1a352
Compare
7f1a352 to
cd54e06
Compare
hardcode-gsettings patch needed rework due to upstream refactoring; from the code, it seems that at least part of it may still be necessary, though I haven’t been able to reproduce the original issue in my own config. Therefore erring on the side of leaving it in. qt6-cursor-fix has been merged and appears to be in this release. Worth noting that qgnomeplatform upstream indicates it is no longer maintained, and that 0.9.2 is the final release.
With qgnomeplatform 0.9.0 and later, dynamic switching of the GNOME theme is performed by default.
cd54e06 to
c6a6bbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
Tested using this config. Some apps work okay, some have wrong theme (mostly qt5, maybe?). Leaving as draft for now for that reason.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.