Skip to content

nixos/qemu: Support System Management Mode#284925

Closed
baloo wants to merge 5 commits intoNixOS:masterfrom
baloo:baloo/qemu-smm
Closed

nixos/qemu: Support System Management Mode#284925
baloo wants to merge 5 commits intoNixOS:masterfrom
baloo:baloo/qemu-smm

Conversation

@baloo
Copy link
Member

@baloo baloo commented Jan 30, 2024

Description of changes

new take on #207043

Mostly a rebase, and adding a test for it as well.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@baloo baloo requested a review from RaitoBezarius as a code owner January 30, 2024 06:01
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 30, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 30, 2024
@adamcstephens adamcstephens mentioned this pull request Jan 30, 2024
Merged
13 tasks
@RaitoBezarius
Copy link
Member

RaitoBezarius commented Jan 30, 2024

Can you verify this PR works with lanzaboote?

@baloo
Copy link
Member Author

baloo commented Jan 30, 2024

yeah, it's broken there.

@baloo baloo marked this pull request as draft January 30, 2024 17:39
@ofborg ofborg bot requested a review from adamcstephens February 5, 2024 03:42
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Feb 5, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@baloo baloo closed this Jun 4, 2024
@baloo baloo deleted the baloo/qemu-smm branch June 4, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@adamcstephens adamcstephens Awaiting requested review from adamcstephens

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baloo @RaitoBezarius @wegank