nixos/etc: remove leading slash from paths#284508
Merged
lheckemann merged 3 commits intoNixOS:masterfrom Feb 3, 2024
Merged
Conversation
…dump.py This is necessary so that duplicates in the composefs dump are avoided.
Even if the tools that assemble /etc can handle leading slashes, this still is not correct. For example, you could have both /X11 and X11 in environment.etc which makes overriding hard.
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
dblsaiko
reviewed
Jan 28, 2024
delroth
added
the
12.approvals: 1
lheckemann
approved these changes
Feb 3, 2024
Member
|
A more proper fix would probably be to disallow leading slashes via an assertion or similar, because the approach here still leaves the collision problem open ("what if both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix issue reported in #270727 (comment)
environment.etcdefined in xserver moduleThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.