Skip to content

faustlive: unpin llvm, update build, fix crash#283824

Merged
NickCao merged 2 commits intomasterfrom
unknown repository
Jan 26, 2024
Merged

faustlive: unpin llvm, update build, fix crash#283824
NickCao merged 2 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jan 25, 2024

Description of changes

depends on #283871 for the backport to apply cleanly.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ghost ghost changed the title faustlive: unpin llvm, update build, fix runtime faustlive: unpin llvm, update build, fix crash Jan 25, 2024
@ghost ghost requested a review from magnetophon January 25, 2024 19:57
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 25, 2024
@ghost ghost removed the backport release-23.11 label Jan 25, 2024
Copy link
Member

@magnetophon magnetophon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Result of nixpkgs-review pr 283824 run on x86_64-linux 1

1 package built:
  • faustlive

@magnetophon magnetophon added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Jan 26, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 26, 2024
@NickCao NickCao merged commit 952b649 into NixOS:master Jan 26, 2024
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@github-actions
Copy link
Contributor

Git push to origin failed for release-23.11 with exitcode 1

@ghost ghost deleted the faustlive-llvm-unpin branch January 26, 2024 03:09
@ghost ghost mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants