Merged
Conversation
ghost
marked this pull request as ready for review
ofborg
bot
added
the
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 1-10
Author
|
Result of 1 package built:
|
wegank
approved these changes
Jan 24, 2024
This comment was marked as resolved.
This comment was marked as resolved.
delroth
added
the
12.approvals: 1
delroth
removed
the
12.approvals: 1
wegank
approved these changes
Jan 25, 2024
delroth
added
the
12.approvals: 1
added 3 commits
January 25, 2024 12:23
darwin is marked broken clang_8 is only used with darwin
removing references to llvmPackages_8 in preparation to drop it from the tree
delroth
removed
the
12.approvals: 1
wegank
approved these changes
Jan 26, 2024
delroth
added
the
12.approvals: 1
ghost
mentioned this pull request
14 tasks
rrbutani
added
the
6.topic: llvm/clang
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
drop llvmPackages_8. There are only two references in nixpkgs that need to be removed.
qv2rayuses clang_8 for darwin, darwin build marked as broken, just remove clang_8windows.crossThreadsStdenvreferences llvmPackages_8 which was added in change 06c5e81. replaced with the llvmPackages alias not clear what is correct or how to test.nixpkgs-review x64 linux
27 packages removed: clang (†8.0.1) clang (†8.0.1) clang-manpages (†8.0.1) clang-tools (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) compiler-rt-libc (†8.0.1) compiler-rt-libc (†8.0.1) libcxx (†8.0.1) libcxxabi (†8.0.1) libunwind (†8.0.1) lld (†8.0.1) lldb (†8.0.1) llvm (†8.0.1) llvm (†8.0.1) llvm (†8.0.1) llvm-binutils (†8.0.1) llvm-binutils-wrapper (†8.0.1) llvm-binutils-wrapper (†8.0.1) openmp (†8.0.1) stdenv-linux (†) stdenv-linux (†)
Nothing to be built.Result of
nixpkgs-reviewrun on x86_64-linux 1nixpkgs-review x64 darwin
27 packages removed: clang (†8.0.1) clang (†8.0.1) clang-manpages (†8.0.1) clang-tools (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) clang-wrapper (†8.0.1) compiler-rt-libc (†8.0.1) compiler-rt-libc (†8.0.1) libcxx (†8.0.1) libcxxabi (†8.0.1) libunwind (†8.0.1) lld (†8.0.1) lldb (†8.0.1) llvm (†8.0.1) llvm (†8.0.1) llvm (†8.0.1) llvm-binutils (†8.0.1) llvm-binutils-wrapper (†8.0.1) llvm-binutils-wrapper (†8.0.1) openmp (†8.0.1) stdenv-darwin (†) stdenv-darwin (†)
Result of `nixpkgs-review` run on x86_64-darwin [1](https://github.com/Mic92/nixpkgs-review)1 package marked as broken and skipped: qv2ray
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.