ghc/hadrian: Respect patches argument#283364
Closed
bgamari wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
84950df to
17cbd62
Compare
Contributor
Author
Member
|
This looks sensible to me. But sterni needs to judge. |
Contributor
|
I ran into exactly this issue a couple of days ago, seems to be a good change to me. |
Contributor
|
@sternenseemann this PR looks good but it is the 5th least recently updated... |
Merged
13 tasks
Member
|
I'd support this use case via #304652 which I think simplifies all the involved expressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously any attempt to patch GHC would be subject to the restriction that patches would not be applied to the source tree used to build Hadrian. This is problematic as frequently Hadrian is evolved in conjunction with the compiler proper. Here we introduce a new
patchesargument to the common Hadrian derivation, allowing the user to specify patches that affect both Hadrian and the compiler build, e.g.:Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.