Skip to content

Comments

Netbox 3.7.1#282929

Merged
RaitoBezarius merged 4 commits intoNixOS:masterfrom
minijackson:netbox-3.7.1
Jan 22, 2024
Merged

Netbox 3.7.1#282929
RaitoBezarius merged 4 commits intoNixOS:masterfrom
minijackson:netbox-3.7.1

Conversation

@minijackson
Copy link
Member

@minijackson minijackson commented Jan 22, 2024 •
edited
Loading

Description of changes

  • add netbox_3_7 at 3.7.1
  • make it the default netbox package
  • make it the default for NixOS if stateVersion >= 24.05
  • make the "netbox-upgrade" NixOS test test the upgrade from 3.6 to 3.7
  • remove netbox_3_5
  • mark netbox_3_6 as EOL

cc @RaitoBezarius

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@minijackson
netbox: 3.6.9 -> 3.7.1
163fed2 
Or another way to see it:

netbox_3_7: init at 3.7.1

Make NetBox 3.7 the default version if stateVersion >= 24.05,
switch upgrade test to test upgrade from 3.6 to 3.7,
remove clearcache command for >=3.7.0,
make reindex command mandatory
@minijackson
netbox_3_5: remove
5d2370f
@minijackson
netbox_3_6: mark as EOL
02f6897
@minijackson
nixos/rl-2405: document NetBox breaking change
da3587e
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 22, 2024
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Jan 22, 2024
@ofborg ofborg bot requested review from RaitoBezarius and n0emis January 22, 2024 16:04
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 22, 2024
@infinisil
Copy link
Member

infinisil commented Jan 22, 2024

You can ignore the pkgs/by-name check failure, this is not a problem of this PR, the check itself needs to be adjusted. Merging this PR won't be a problem for pkgs/by-name.

@lukegb
Copy link
Contributor

lukegb commented Jan 22, 2024

In your description you write

add netbox_3_4 at 3.7.1

Did you mean netbox_3_7?

@minijackson
Copy link
Member Author

minijackson commented Jan 22, 2024

@lukegb yes that's a typo. Fixed it, thanks!

@RaitoBezarius
Copy link
Member

RaitoBezarius commented Jan 22, 2024

Result of nixpkgs-review pr 282929 run on x86_64-linux 1

1 test built:
  • nixosTests.netbox_3_7

@RaitoBezarius
Copy link
Member

RaitoBezarius commented Jan 22, 2024

Result of nixpkgs-review pr 282929 run on x86_64-linux 1

1 package marked as broken and skipped:
  • netbox_3_6
2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
1 package built:
  • netbox (netbox_3_7)

@RaitoBezarius
Copy link
Member

RaitoBezarius commented Jan 22, 2024

I tested also the upgrade, seems to work fine, but I don't have permissions to deploy my non-trivial production Netbox, so I cannot test there. I think we can move on.

@RaitoBezarius RaitoBezarius merged commit 32a6e22 into NixOS:master Jan 22, 2024
@infinisil infinisil mentioned this pull request Jan 31, 2024
Merged
@infinisil
Copy link
Member

infinisil commented Jan 31, 2024

You can ignore the pkgs/by-name check failure, this is not a problem of this PR, the check itself needs to be adjusted. Merging this PR won't be a problem for pkgs/by-name.

Will be fixed with #285089

@minijackson minijackson deleted the netbox-3.7.1 branch March 24, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@n0emis n0emis Awaiting requested review from n0emis

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@minijackson @infinisil @lukegb @RaitoBezarius