[staging-next] Some staging fixes#282536
Merged
vcunat merged 2 commits intoNixOS:staging-nextfrom Jan 22, 2024
Merged
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
requested review from
Atemu,
FRidh,
WilliButz,
anthonyroussel,
arthsmn,
cpages,
doronbehar and
gbtb
ofborg
bot
added
10.rebuild-darwin: 501+
doronbehar
reviewed
Jan 21, 2024
It actually builds and seems to be preferred upstream anyway: FFmpeg/FFmpeg@da72aca
Fixes the pkgs/by-name check
K900
force-pushed
the
some-staging-fixes
branch
from
2312668 to
099029f
Compare
github-actions
bot
removed
the
6.topic: python
Member
|
Have you verified that ffmpeg_{4,5}-full still build using this flag? |
Contributor
Author
|
Yes. |
Member
|
Have you really? Adjusted in 78b0905 |
Contributor
Author
|
I thought I did :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.