Skip to content

python311Packages.scipy: 1.11.4 -> 1.12.0#282506

Merged
vcunat merged 6 commits intoNixOS:staging-nextfrom
doronbehar:pkg/scipy
Jan 22, 2024
Merged

python311Packages.scipy: 1.11.4 -> 1.12.0#282506
vcunat merged 6 commits intoNixOS:staging-nextfrom
doronbehar:pkg/scipy

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jan 21, 2024 •
edited by SuperSandro2000
Loading

Motivation for this change

Closes #277306

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request Jan 21, 2024
Closed
14 tasks
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 21, 2024
@doronbehar
Copy link
Contributor Author

doronbehar commented Jan 21, 2024 •
edited
Loading

Runnning now:

nom build -Lf. --max-jobs 1 --cores 2 {,pkgsi686Linux.,pkgsCross.{aarch64,armv7l-hf}-multiplatform.}python31{0,1}Packages.scipy

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Jan 21, 2024
@ofborg ofborg bot requested a review from FRidh January 21, 2024 07:43
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 21, 2024
@doronbehar doronbehar changed the title python311Packages.scipy: actually use pytestCheckHook python311Packages.scipy: 1.11.4 -> 1.12.0 Jan 21, 2024
@doronbehar doronbehar mentioned this pull request Jan 21, 2024
Merged
13 tasks
@doronbehar doronbehar marked this pull request as draft January 21, 2024 11:30
@doronbehar doronbehar changed the base branch from staging to staging-next January 21, 2024 11:30
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 6.topic: emacs Text editor labels Jan 21, 2024
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 6.topic: emacs Text editor labels Jan 21, 2024
@doronbehar doronbehar marked this pull request as ready for review January 21, 2024 11:32
SuperSandro2000
SuperSandro2000 approved these changes Jan 21, 2024
View reviewed changes
pkgs/development/python-modules/scipy/default.nix
--replace 'numpy==' 'numpy>=' \
--replace "pybind11>=2.10.4,<2.11.1" "pybind11>=2.10.4,<2.12.0" \
--replace 'wheel<0.41.0' 'wheel'
--replace-fail 'numpy==' 'numpy>=' \
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use pythonRelaxDepsHook here?

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 21, 2024
@vcunat vcunat merged commit 275471a into NixOS:staging-next Jan 22, 2024
@vcunat
Copy link
Member

vcunat commented Jan 22, 2024

It fixes scipy build and doesn't look bad, so let's move on.

@vcunat
Copy link
Member

vcunat commented Jan 23, 2024

@DavHau: python3Packages.scikit-learn needs to react to this somehow I guess?
https://hydra.nixos.org/build/247211840/nixlog/1/tail

@doronbehar
Copy link
Contributor Author

doronbehar commented Jan 23, 2024 via email

@doronbehar
Copy link
Contributor Author

doronbehar commented Jan 24, 2024

scikit-learn seems to build fine on staging-next now.

@vcunat
Copy link
Member

vcunat commented Jan 24, 2024 •
edited
Loading

It's still failing the same for me. (x86_64 NixOS, two different machines)

@bryango bryango mentioned this pull request Jan 25, 2024
Merged
13 tasks
@bryango
Copy link
Member

bryango commented Jan 25, 2024

@DavHau @doronbehar @vcunat scikit-learn failure may be fixed by a version bump, see #283666.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@doronbehar @vcunat @bryango @SuperSandro2000 @delroth