Skip to content

Comments

gtest: 1.12.1 -> 1.14.0#282245

Merged
lukegb merged 1 commit intoNixOS:stagingfrom
simonhollingshead:gtest1140
Feb 10, 2024
Merged

gtest: 1.12.1 -> 1.14.0#282245
lukegb merged 1 commit intoNixOS:stagingfrom
simonhollingshead:gtest1140

Conversation

@simonhollingshead
Copy link
Member

@simonhollingshead simonhollingshead commented Jan 20, 2024

Description of changes

From v1.13.0 onwards, C++14 or later is required. v1.12.1 supported C++11.

https://github.com/google/googletest/releases/tag/v1.13.0
https://github.com/google/googletest/releases/tag/v1.14.0

As this will require a large rebuild, this change is targeting staging.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes labels Jan 20, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 20, 2024
@simonhollingshead simonhollingshead force-pushed the gtest1140 branch 2 times, most recently from 6810550 to 3dcfe1c Compare January 20, 2024 07:15
@simonhollingshead simonhollingshead marked this pull request as ready for review January 20, 2024 07:19
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 20, 2024
@ofborg ofborg bot requested a review from ivan-tkatchev January 20, 2024 07:42
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 20, 2024
@cbourjau cbourjau mentioned this pull request Jan 21, 2024
Merged
12 tasks
mweinelt
mweinelt reviewed Feb 7, 2024
View reviewed changes
@mweinelt
Copy link
Member

mweinelt commented Feb 7, 2024

The release note URLs should go into the commit message.

@lukegb lukegb merged commit 4034b75 into NixOS:staging Feb 10, 2024
@simonhollingshead simonhollingshead deleted the gtest1140 branch February 11, 2024 01:32
@vcunat
Copy link
Member

vcunat commented Feb 19, 2024 •
edited
Loading

So, who will be dealing with packages that use older C++?

@mweinelt
Copy link
Member

mweinelt commented Feb 19, 2024

Bumping to the latest upstream commit for rapidjson did not help.

@lukegb
Copy link
Contributor

lukegb commented Feb 19, 2024

I'll take a peek at rapidjson unless someone beats me to it

@cbourjau cbourjau mentioned this pull request Feb 20, 2024
Merged
13 tasks
@lukegb
Copy link
Contributor

lukegb commented Feb 20, 2024

#290250 for rapidjson

@simonhollingshead simonhollingshead mentioned this pull request Feb 22, 2024
Merged
13 tasks
@simonhollingshead
Copy link
Member Author

simonhollingshead commented Feb 22, 2024

@vcunat I am proposing a fix for libqtdbustest in #290647.

I have found only two(?) other packages I think are impacted and will also provide fixes for those.

@simonhollingshead simonhollingshead mentioned this pull request Feb 22, 2024
Merged
13 tasks
@simonhollingshead simonhollingshead mentioned this pull request Feb 22, 2024
Merged
13 tasks
@simonhollingshead
Copy link
Member Author

simonhollingshead commented Feb 22, 2024

@vcunat You've caught a couple more than me. The two I have seen fail are net-cpp and (I believe) itpp, but itpp's logs in hydra are missing and just show an error.

This was referenced Feb 22, 2024
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
@simonhollingshead
Copy link
Member Author

simonhollingshead commented Feb 23, 2024

I believe that I've now interacted with all x86-64 linux builds where the error message contains the C++14 gtest error message.

All are associated with this PR, above.

Note that in four cases, I've either nudged an existing version bump PR or filed an update request. These are all cases where upstream have fixed gtest but where there seems to be some complicating factor (e.g. just updating to a new version causes a compile error unrelated to gtest, or one thing can't update until some other thing is ready). In these cases I feel it's better to defer to maintainers.

@vcunat
Copy link
Member

vcunat commented Feb 23, 2024

Amazing amount of work ❤️

This was referenced Feb 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt left review comments

@lukegb lukegb lukegb approved these changes

@ivan-tkatchev ivan-tkatchev Awaiting requested review from ivan-tkatchev

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simonhollingshead @mweinelt @vcunat @lukegb