top-level: use callPackages where inheriting packages#282015
Merged
NickCao merged 1 commit intoNixOS:masterfrom Jan 19, 2024
Merged
top-level: use callPackages where inheriting packages#282015NickCao merged 1 commit intoNixOS:masterfrom
NickCao merged 1 commit intoNixOS:masterfrom
Conversation
otherwise those packages cannot be overriden Resubmition because of revert in NixOS#281932
This was referenced Jan 19, 2024
Member
Author
|
Thanks! If there happens to be another issue, please give me a ping and I take a look into it. |
Member
|
This should have been backported because this is a bugfix. |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-282015-to-release-23.11 origin/release-23.11
cd .worktree/backport-282015-to-release-23.11
git switch --create backport-282015-to-release-23.11
git cherry-pick -x a276e8b09bf0eb21ff2f46cf8680edc16cc517c2 |
Member
|
Backport in #297051 |
Member
Author
Since this was the second try already and fully testing this is kinda cumbersome, I was a bit conservative of backporting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
otherwise those packages cannot be overriden
With this change they can be overriden
Resubmition because of revert in #281932 because of an oversight of me.
I tested this with
I used python3Packages.dash instead of fetchYarnDeps because that cannot be directly evaluated.
Please merge this before the next nixos-unstable otherwise we leave configs broken with evaluation errors.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.