spirv-llvm-translator: cherry-pick a patch to fix build with latest spirv-headers#282006
Merged
K900 merged 1 commit intoNixOS:staging-nextfrom Jan 19, 2024
Merged
spirv-llvm-translator: cherry-pick a patch to fix build with latest spirv-headers#282006K900 merged 1 commit intoNixOS:staging-nextfrom
K900 merged 1 commit intoNixOS:staging-nextfrom
Conversation
Member
|
Is that patch only required for a specific LLVM version or starting from a version? It doesn't apply when using the llvm 14 branch and through that breaks intel-graphics-compiler and intel-compute-runtime. |
SuperSandro2000
added a commit
to SuperSandro2000/nixpkgs
that referenced
this pull request
Jan 27, 2024
Contributor
Author
|
It should be required for all versions, but it might need backporting... Is there a reason Intel stuff is stuck on 14? Can we not update it instead? |
Member
|
That is what upstream is using and their code in intel-graphics-compiler is hairy and often enough breaks even in the current branch. I don't think we can lift that to some other major version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Renaming public API woo
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.