Skip to content

Comments

Vulkan 1.3.275#281591

Merged
K900 merged 12 commits intoNixOS:stagingfrom
K900:vulkan-bumps
Jan 17, 2024
Merged

Vulkan 1.3.275#281591
K900 merged 12 commits intoNixOS:stagingfrom
K900:vulkan-bumps

Conversation

@K900
Copy link
Contributor

@K900 K900 commented Jan 17, 2024

Description of changes

New SDK release.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@K900 K900 requested review from NickCao, Ralith and reckenrode January 17, 2024 17:41
K900 added 12 commits January 17, 2024 20:42
@K900
Copy link
Contributor Author

K900 commented Jan 17, 2024

Overall pretty painless update this time. vulkan-volk because volk is taken.

@K900 K900 merged commit 34227d1 into NixOS:staging Jan 17, 2024
@trofi
Copy link
Contributor

trofi commented Jan 19, 2024

Bisect says that b52d852 spirv-headers: 1.3.268.0 -> 1.3.275.0 broke spirv-llvm-translator in staging and staging-next as:

$ nix build --no-link -f. spirv-llvm-translator -L
...
SPIRV-LLVM-Translator> [ 48%] Building CXX object lib/SPIRV/CMakeFiles/LLVMSPIRVLib.dir/SPIRVToLLVMDbgTran.cpp.o
SPIRV-LLVM-Translator> In file included from /build/source/lib/SPIRV/SPIRVInternal.h:45,
SPIRV-LLVM-Translator>                  from /build/source/lib/SPIRV/VectorComputeUtil.h:43,
SPIRV-LLVM-Translator>                  from /build/source/lib/SPIRV/VectorComputeUtil.cpp:39:
SPIRV-LLVM-Translator> /build/source/lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h: In member function 'void SPIRV::SPIRVMap<Ty1, Ty2, Identifier>::init() [with Ty1 = spv::Capability; Ty2 = std::__cxx11::basic_string<char>; Identifier = void]':
SPIRV-LLVM-Translator> /build/source/lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h:607:7: error: 'CapabilityLongConstantCompositeINTEL' was not declared in this scope
SPIRV-LLVM-Translator>   607 |   add(CapabilityLongConstantCompositeINTEL, "LongConstantCompositeINTEL");
SPIRV-LLVM-Translator>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@Ralith
Copy link
Contributor

Ralith commented Jan 19, 2024

Looks like that was renamed to LongCompositesINTEL in KhronosGroup/SPIRV-Headers@d5acd42.

@K900
Copy link
Contributor Author

K900 commented Jan 19, 2024

Fixed in #282006

@zeuner
Copy link
Contributor

zeuner commented Jan 21, 2024

Not sure why this was merged as-is since it breaks subsequent CI due to disregarding the pkgs/by-name policy: https://github.com/NixOS/nixpkgs/actions/runs/7600068348/job/20697863923?pr=282473

@K900
Copy link
Contributor Author

K900 commented Jan 21, 2024

This was merged into staging before the pkgs/by-name enforcement, which was merged into master.

@K900
Copy link
Contributor Author

K900 commented Jan 21, 2024

I'm moving those packages to by-name in #282536

@vcunat
Copy link
Member

vcunat commented Feb 4, 2024

BTW, 1.3.277 adds VK_KHR_video_decode_av1. Sounds interesting, over longer term at least.

@K900 K900 deleted the vulkan-bumps branch July 27, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants