Skip to content

Comments

python3Packages.sip: 6.8.0 -> 6.8.1#281180

Merged
dotlambda merged 2 commits intostaging-nextfrom
sip-6.8.1
Jan 24, 2024
Merged

python3Packages.sip: 6.8.0 -> 6.8.1#281180
dotlambda merged 2 commits intostaging-nextfrom
sip-6.8.1

Conversation

@imincik
Copy link
Contributor

@imincik imincik commented Jan 15, 2024 •
edited by dotlambda
Loading

Description of changes

Patch update of SIP fixing multiple regressions introduced in v6.8.0 and causing many build failures (for example #281100)

See: https://riverbankcomputing.com/news/SIP_v6.8.1_Released
and https://www.riverbankcomputing.com/hg/sip/file/tip/NEWS

fixes #281100
closes #282473

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 15, 2024
@imincik imincik requested a review from mweinelt January 15, 2024 17:19
@imincik imincik mentioned this pull request Jan 15, 2024
Closed
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 15, 2024

Please add a Closes #281100 to the PR body.

SuperSandro2000
SuperSandro2000 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@imincik
Copy link
Contributor Author

imincik commented Jan 15, 2024

@mweinelt , should this PR go to python-updates or staging branch instead of master ?

@dotlambda
Copy link
Member

dotlambda commented Jan 15, 2024

Why not update to 6.8.2?

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 15, 2024
@imincik
Copy link
Contributor Author

imincik commented Jan 15, 2024

Why not update to 6.8.2?

6.8.2 release is not yet announced in news. I am not sure whether it is released or not.

@ofborg ofborg bot requested a review from nrdxp January 15, 2024 22:43
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 15, 2024
@kirillrdy
Copy link
Member

kirillrdy commented Jan 15, 2024

@mweinelt , should this PR go to python-updates or staging branch instead of master ?

3109 packages updated:

If there is no currently active python-updates branch, then this should go to staging

@dotlambda
Copy link
Member

dotlambda commented Jan 15, 2024

Why not update to 6.8.2?

6.8.2 release is not yet announced in news. I am not sure whether it is released or not.

https://www.riverbankcomputing.com/hg/sip/file/tip/NEWS lists it as released on December 31.

@imincik
Copy link
Contributor Author

imincik commented Jan 16, 2024

Why not update to 6.8.2?

@dotlambda , version 6.8.2 is not on PyPi (which is the source repo for this package).

@imincik imincik changed the base branch from master to staging January 16, 2024 08:35
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 16, 2024
@nixos-discourse
Copy link

nixos-discourse commented Jan 16, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/3

@imincik
Copy link
Contributor Author

imincik commented Jan 23, 2024 •
edited
Loading

@vcunat , would you please include this PR in #281828 ? Thanks .

@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jan 23, 2024
@Stunkymonkey Stunkymonkey mentioned this pull request Jan 23, 2024
Closed
13 tasks
@dotlambda dotlambda changed the base branch from staging to staging-next January 24, 2024 00:39
@dotlambda
python311Packages.sip: add poppler-qt5 to passthru.tests
6f441b4 
It breaks on sip 6.8.0 with

    NameError: name 'SocstringSignature' is not defined. Did you mean: 'DocstringSignature'?
@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jan 24, 2024
@dotlambda
Copy link
Member

dotlambda commented Jan 24, 2024

Why does aarch64-darwin fail with

error: attribute 'tests' in selection path 'python311Packages.sip.passthru.tests' not found

?

@delroth delroth added the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Jan 24, 2024
@kirillrdy
Copy link
Member

kirillrdy commented Jan 24, 2024

Why does aarch64-darwin fail with

error: attribute 'tests' in selection path 'python311Packages.sip.passthru.tests' not found

?

see if pythonPackages.poppler-qt5 builds on aarch64-darwin even with this change, maybe try ofborg ?

@dotlambda
Copy link
Member

dotlambda commented Jan 24, 2024

see if pythonPackages.poppler-qt5 builds on aarch64-darwin even with this change, maybe try ofborg ?

That shouldn't change whether the attribute 'tests' exists. Anyway:
@ofborg build python3Packages.poppler-qt5

@kirillrdy
Copy link
Member

kirillrdy commented Jan 24, 2024

see if pythonPackages.poppler-qt5 builds on aarch64-darwin even with this change, maybe try ofborg ?

That shouldn't change whether the attribute 'tests' exists. Anyway: @ofborg build python3Packages.poppler-qt5

I've seen that error before, when one of tests dependencies was not supported on that platform, I assumed it's normal

@dotlambda dotlambda merged commit 0d074a5 into staging-next Jan 24, 2024
@dotlambda dotlambda deleted the sip-6.8.1 branch January 24, 2024 02:59
@imincik
Copy link
Contributor Author

imincik commented Jan 24, 2024

Thanks for moving this forward !

@imincik imincik mentioned this pull request Jan 25, 2024
Merged
13 tasks
@nixos-discourse
Copy link

nixos-discourse commented Jan 30, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stunkymonkey Stunkymonkey Stunkymonkey approved these changes

@dotlambda dotlambda dotlambda approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

@nrdxp nrdxp Awaiting requested review from nrdxp

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: qgis build is failing during sip-build

7 participants

@imincik @SuperSandro2000 @dotlambda @kirillrdy @nixos-discourse @Stunkymonkey @delroth