Conversation
github-actions
bot
added
the
6.topic: python
Member
|
@ofborg eval |
ofborg
bot
added
10.rebuild-darwin: 11-100
Member
|
Result of 2 packages marked as broken and skipped:
37 packages failed to build:
13 packages built:
|
Comment on lines
49
to
50
Member
There was a problem hiding this comment.
I don't think we need to propdate both. Also is the python package not already including the cli?
Contributor
Author
There was a problem hiding this comment.
The build fails using only the Python package with an absl errors like the following:
In file included from /tmp/nix-build-python3.11-onnx-1.15.0.drv-1/source/.setuptools-cmake-build/onnx/onnx-operators-ml.pb.cc:4:
In file included from /tmp/nix-build-python3.11-onnx-1.15.0.drv-1/source/.setuptools-cmake-build/onnx/onnx-operators-ml.pb.h:24:
In file included from /nix/store/glnr34k9z7qwrhcpnrp77b83h3mgfhiq-protobuf-24.4/include/google/protobuf/io/coded_stream.h:134:
In file included from /nix/store/mid900708j8vgfrkd5yfxn48f7x4pspc-abseil-cpp-20230125.3/include/absl/strings/cord.h:78:
In file included from /nix/store/mid900708j8vgfrkd5yfxn48f7x4pspc-abseil-cpp-20230125.3/include/absl/container/inlined_vector.h:53:
In file included from /nix/store/mid900708j8vgfrkd5yfxn48f7x4pspc-abseil-cpp-20230125.3/include/absl/container/internal/inlined_vector.h:30:
In file included from /nix/store/mid900708j8vgfrkd5yfxn48f7x4pspc-abseil-cpp-20230125.3/include/absl/container/internal/compressed_tuple.h:40:
/nix/store/mid900708j8vgfrkd5yfxn48f7x4pspc-abseil-cpp-20230125.3/include/absl/utility/utility.h:164:12: error: no member named 'in_place_t' in namespace 'std'
Using only protobuf_21 won't work since protobuf is use from Python in the final package.
Contributor
|
@Scrumplex if you have some details on the build failures, I'm curious. |
cbourjau
force-pushed
the
fix-onnx-darwin
branch
from
b58bf12 to
9d73e4c
Compare
Contributor
Author
|
Thanks for the feedback! There is still something strange going on with protobuf. More context can be found in #281065 |
Member
Some of them were unrelated.
looking at the full log, the following errors appear:
|
12 tasks
Member
|
Apparently, fixing While naively updating onnxruntime does build fine, several tests fail. It seems like we need to wait for Diff to update onnxruntime to 1.16.3: diff --git a/pkgs/development/libraries/onnxruntime/default.nix b/pkgs/development/libraries/onnxruntime/default.nix
index 7a8b8570f62c..27d48e0b8c53 100644
--- a/pkgs/development/libraries/onnxruntime/default.nix
+++ b/pkgs/development/libraries/onnxruntime/default.nix
@@ -33,8 +33,8 @@ let
eigen = fetchFromGitLab {
owner = "libeigen";
repo = "eigen";
- rev = "d10b27fe37736d2944630ecd7557cefa95cf87c9";
- sha256 = "sha256-Lmco0s9gIm9sIw7lCr5Iewye3RmrHEE4HLfyzRkQCm0=";
+ rev = "e7248b26a1ed53fa030c5c459f7ea095dfd276ac";
+ sha256 = "sha256-uQ1YYV3ojbMVfHdqjXRyUymRPjJZV3WHT36PTxPRius=";
};
mp11 = fetchFromGitHub {
@@ -78,13 +78,13 @@ let
in
stdenv.mkDerivation rec {
pname = "onnxruntime";
- version = "1.15.1";
+ version = "1.16.3";
src = fetchFromGitHub {
owner = "microsoft";
repo = "onnxruntime";
rev = "v${version}";
- sha256 = "sha256-SnHo2sVACc++fog7Tg6f2LK/Sv/EskFzN7RZS7D113s=";
+ sha256 = "sha256-bTW9Pc3rvH+c8VIlDDEtAXyA3sajVyY5Aqr6+SxaMF4=";
fetchSubmodules = true;
};
|
Member
|
So that one also won't work until onnxruntime 1.17.0 releases or someone backports relevant changes |
Contributor
|
Thank you for taking the time! |
12 tasks
Member
|
I don't think anything blocks this PR specifically. It should be good to be merged. The other packages require their own fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ONNX package is broken since #271586. This is due to protobuf issues and missing dependencies for running the test suite.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.