Skip to content

docker-distribution: 2.8.3 -> 3.0.0-alpha.1#280911

Merged
katexochen merged 5 commits intoNixOS:masterfrom
katexochen:distribution/3
Jun 19, 2024
Merged

docker-distribution: 2.8.3 -> 3.0.0-alpha.1#280911
katexochen merged 5 commits intoNixOS:masterfrom
katexochen:distribution/3

Conversation

@katexochen
Copy link
Contributor

@katexochen katexochen commented Jan 14, 2024 •
edited
Loading

Description of changes

Project now seems to be independent of docker.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@katexochen katexochen changed the title Distribution/3 docker-distribution: 2.8.3 -> 3.0.0-alpha.1 Jan 14, 2024
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 14, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@katexochen katexochen mentioned this pull request Jun 7, 2024
Closed
35 tasks
@katexochen katexochen removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 17, 2024
@katexochen katexochen marked this pull request as ready for review June 17, 2024 19:15
@katexochen katexochen requested a review from msanft June 18, 2024 19:42
@msanft
Copy link
Contributor

msanft commented Jun 18, 2024

Result of nixpkgs-review pr 280911 run on x86_64-linux 1

1 package built:
  • distribution

@katexochen katexochen added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 19, 2024
@katexochen katexochen merged commit e3eac43 into NixOS:master Jun 19, 2024
@katexochen katexochen deleted the distribution/3 branch June 19, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msanft msanft msanft approved these changes

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@katexochen @msanft @wegank