{libedit,sharutils}: move env vars to env.*#280665
Merged
wegank merged 1 commit intoNixOS:masterfrom Jan 17, 2024
Merged
Conversation
NixOSInfra
added
the
12.first-time contribution
magneticflux-
changed the title
env.*env.*
magneticflux-
force-pushed
the
libedit
branch
2 times, most recently
from
9e933cf to
7eea003
Compare
wegank
reviewed
Jan 13, 2024
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
Seems like |
Member
|
LGTM. Please rebase and squash the commits, thanks. |
Closes NixOS#273746 See NixOS#217206 Co-authored-by: Weijia Wang <[email protected]>
magneticflux-
force-pushed
the
libedit
branch
from
2ef72a5 to
d0f90d9
Compare
Contributor
Author
|
@wegank Everything look good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #273746 See #217206
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.