Skip to content

xorg.imake: 1.0.9 -> 1.0.10#280122

Merged
NickCao merged 1 commit intoNixOS:stagingfrom
NickCao:imake
Jan 29, 2024
Merged

xorg.imake: 1.0.9 -> 1.0.10#280122
NickCao merged 1 commit intoNixOS:stagingfrom
NickCao:imake

Conversation

@NickCao
Copy link
Member

@NickCao NickCao commented Jan 10, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NickCao NickCao changed the base branch from master to staging January 10, 2024 21:35
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 16, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 21, 2024
@NickCao
Copy link
Member Author

NickCao commented Jan 29, 2024

xorg.imake.tests.pkg-config is also failing on master.

@NickCao NickCao merged commit 7f1bcfd into NixOS:staging Jan 29, 2024
@NickCao NickCao deleted the imake branch January 29, 2024 01:25
@trofi
Copy link
Contributor

trofi commented Jan 29, 2024

Good catch! That fails because xorg.* hierarchy produces tests for packages with zero modules.

Proposed the fix as #284740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants