Skip to content

Comments

redis: 7.2.3 -> 7.2.4#280117

Merged
risicle merged 1 commit intoNixOS:stagingfrom
LeSuisse:redis-7.2.4
Jan 11, 2024
Merged

redis: 7.2.3 -> 7.2.4#280117
risicle merged 1 commit intoNixOS:stagingfrom
LeSuisse:redis-7.2.4

Conversation

@LeSuisse
Copy link
Member

@LeSuisse LeSuisse commented Jan 10, 2024

Description of changes

Fixes CVE-2023-41056.

https://github.com/redis/redis/releases/tag/7.2.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Also built pkgsStatic.redis.

Add a 👍 reaction to pull requests you find important.

@LeSuisse LeSuisse added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-23.11 labels Jan 10, 2024
@ofborg ofborg bot requested review from globin and marsam January 10, 2024 23:03
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 10, 2024
@LeSuisse
Copy link
Member Author

LeSuisse commented Jan 11, 2024

I'm a bit surprised by the amount of rebuilds. The last upgrade in #264857 was far more reasonable. Did I miss something?

@LeSuisse LeSuisse changed the base branch from master to staging January 11, 2024 21:36
@LeSuisse
Copy link
Member Author

LeSuisse commented Jan 11, 2024

Rebased on top of staging.

@risicle
Copy link
Contributor

risicle commented Jan 11, 2024

Tested when still on master. Builds, macos 12 x86_64. passthru.tests passes nixos x86_64. pkgsStatic, pkgsCross.aarch64-multiplatform, pkgsi686Linux variants build.

@risicle risicle merged commit be45dc8 into NixOS:staging Jan 11, 2024
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2024

Successfully created backport PR for staging-23.11:

@LeSuisse LeSuisse deleted the redis-7.2.4 branch January 11, 2024 22:58
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 14, 2024 •
edited
Loading

Sadly this doesn't include redis/redis#12887 and I currently cannot compile redis...

I'm a bit surprised by the amount of rebuilds. The last upgrade in #264857 was far more reasonable. Did I miss something?

ofborg eval didn't finish, so I have no clue either but we should try to reduce this again if possible.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 14, 2024
Merged
13 tasks
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 14, 2024 •
edited
Loading

I'm a bit surprised by the amount of rebuilds. The last upgrade in #264857 was far more reasonable. Did I miss something?

I have a strong suspicion that this is because of #264024. #280372 finished ofborg eval and the few packages I checked had all mocket which recently increased it's deps dramatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@risicle risicle risicle approved these changes

@marsam marsam Awaiting requested review from marsam

@globin globin Awaiting requested review from globin

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LeSuisse @risicle @SuperSandro2000