linuxPackages.amdgpu-pro: use libffi_3_3, not an override#280002
Merged
wegank merged 1 commit intoNixOS:masterfrom Jan 10, 2024
Merged
linuxPackages.amdgpu-pro: use libffi_3_3, not an override#280002wegank merged 1 commit intoNixOS:masterfrom
libffi_3_3, not an override#280002wegank merged 1 commit intoNixOS:masterfrom
Conversation
Without the change `amdgpu-pro` tried to build `libffi-3.3` with patches
for `libffi-3.4` and failed as:
patching file include/ffi_common.h
Hunk #1 succeeded at 103 with fuzz 2 (offset -25 lines).
can't find file to patch at input line 36
THe change uses `libffi_3_3` instead.
Closes: NixOS#279955
Contributor
Author
|
/cc @corngood |
ofborg
bot
added
10.rebuild-darwin: 0
corngood
approved these changes
Jan 10, 2024
delroth
added
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change
amdgpu-protried to buildlibffi-3.3with patches forlibffi-3.4and failed as:THe change uses
libffi_3_3instead.Closes: #279955
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.