Merged
Conversation
ofborg
bot
added
8.has: package (new)
AndersonTorres
suggested changes
Jan 5, 2024
Comment on lines
58
to
62
Member
There was a problem hiding this comment.
Suggested change
| installPhase = '' | |
| runHook preInstall | |
| mkdir $out | |
| ninja install | |
| runHook postInstall | |
| ''; | |
| preInstall = '' | |
| mkdir $out | |
| ''; |
Contributor
Author
There was a problem hiding this comment.
it doesn't work because /nix/store/<hash>-pypa-install-hook/nix-support/setup-hook: line 8: pushd: dist: No such file or directory and because pypaInstallPhase doesn't run ninja install
Contributor
Author
sund3RRR
force-pushed
the
errands-init
branch
from
cd7c3a7 to
138dd94
Compare
drupol
reviewed
Jan 26, 2024
sund3RRR
force-pushed
the
errands-init
branch
from
138dd94 to
4a5c997
Compare
sund3RRR
force-pushed
the
errands-init
branch
from
4a5c997 to
58b77dd
Compare
Contributor
Author
Contributor
|
I'm sorry I can't really review python stuff, I'm not into it. |
Member
AndersonTorres
left a comment
AndersonTorres
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 278951 run on x86_64-linux 1
1 package built:
- errands
sund3RRR
force-pushed
the
errands-init
branch
from
58b77dd to
f891af5
Compare
AndersonTorres
approved these changes
Jan 31, 2024
sund3RRR
force-pushed
the
errands-init
branch
from
f891af5 to
5a5f0a8
Compare
Contributor
Author
AndersonTorres
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Errands is an app that can help you manage your tasks
https://github.com/mrvladus/Errands
I know about #277705, so we can think about it here. mrvladus worries that the packaging of the application in
nixwill require additional support from him. imo, the application is made very competently, conforming to general standards and rules, so there were no problems with packaging innixpkgs.Even if we have to close this PR, we will have at least a working derivation of Errands.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.