emacsPackages.codeium: refactor with melpaBuild#278918
Merged
jian-lin merged 1 commit intoNixOS:masterfrom Jan 6, 2024
Merged
Conversation
13 tasks
ofborg
bot
added
11.by: package-maintainer
AndersonTorres
approved these changes
Jan 5, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
delroth
added
the
12.approvals: 1
jian-lin
reviewed
Jan 5, 2024
pkgs/applications/editors/emacs/elisp-packages/manual-packages/codeium/default.nix
Outdated
Show resolved
Hide resolved
jian-lin
approved these changes
Jan 5, 2024
Contributor
jian-lin
left a comment
jian-lin
left a comment
There was a problem hiding this comment.
LGTM
Could you rebase these commits into one?
delroth
added
12.approvals: 2
running-grass
force-pushed
the
update-codeium
branch
from
5c4b424 to
bfb4abb
Compare
Contributor
Author
over |
delroth
removed
the
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
refactor build from trivialBuild to melpaBuild
Resolve this conversation
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.