Skip to content

Libedit: update and adopt#278061

Merged
vcunat merged 2 commits intoNixOS:stagingfrom
atorres1985-contrib:libedit
Feb 29, 2024
Merged

Libedit: update and adopt#278061
vcunat merged 2 commits intoNixOS:stagingfrom
atorres1985-contrib:libedit

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jan 1, 2024

Description of changes

Picking #278049

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres changed the base branch from master to staging January 1, 2024 13:14
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. and removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Jan 1, 2024
@AndersonTorres AndersonTorres marked this pull request as ready for review January 1, 2024 13:18
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 1, 2024
@ofborg ofborg bot requested review from WilliButz, anthonyroussel and gbtb January 1, 2024 13:50
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 1, 2024
@nixos-discourse
Copy link

nixos-discourse commented Jan 4, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3210

@AndersonTorres AndersonTorres mentioned this pull request Feb 13, 2024
Merged
@nixos-discourse
Copy link

nixos-discourse commented Feb 13, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3435

@AndersonTorres
libedit: migrate to by-name hierarchy
7047d0d
@AndersonTorres
libedit: refactor and adopt
305bb10 
- finalAttrs design pattern
- remove pname parameterization
- split man output
- postFixup instead of postInstall
- remove nested with
- adopt by AndersonTorres
@ofborg ofborg bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Feb 13, 2024
jtbx
jtbx reviewed Feb 13, 2024
View reviewed changes
@vcunat vcunat merged commit 5ec0e03 into NixOS:staging Feb 29, 2024
@Sigmanificient Sigmanificient added the 0.kind: package adoption Requests or PRs for adopting packages that have no maintainers label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbsds pbsds pbsds left review comments

@WilliButz WilliButz Awaiting requested review from WilliButz

@anthonyroussel anthonyroussel Awaiting requested review from anthonyroussel

@gbtb gbtb Awaiting requested review from gbtb

+1 more reviewer

@jtbx jtbx jtbx left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.kind: package adoption Requests or PRs for adopting packages that have no maintainers 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AndersonTorres @nixos-discourse @pbsds @jtbx @vcunat @Sigmanificient