python3Packages.scipy: Disable tests on i686#277306
Closed
eliandoran wants to merge 1 commit intoNixOS:masterfrom
Closed
python3Packages.scipy: Disable tests on i686#277306eliandoran wants to merge 1 commit intoNixOS:masterfrom
eliandoran wants to merge 1 commit intoNixOS:masterfrom
Conversation
a21fe4d to
e0d3df4
Compare
Contributor
Author
|
@SuperSandro2000 , done. Please re-review. |
SuperSandro2000
approved these changes
Jan 8, 2024
e0d3df4 to
97b257a
Compare
Member
|
@ofborg build pkgsi686Linux.python3Packages.scipy |
Member
|
Fails again :/ |
Contributor
|
Hey, let's revise this in scipy's update to staging what do you think? Here's a PR: |
13 tasks
Contributor
|
On staging, with scipy 1.12.0: |
Contributor
|
I'm closing this as OP seems to not care about this anymore, and scipy is updated in #299864 which may change the experience regarding i686. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
scipy fails on
nixos-23.11(i686-linux) with the following error:The errors can be tracked down to two issues in upstream, #12931 and #17912. One of them should have already been fixed by a bump of numpy (but it didn't seem to work). Disabling them on i686 allows the build to run.
The build for
scipydoes not work onmasterat the moment since it fails with:This is an upstream bug in
xsimdthat was fixed in a later version (see xtensor-stack/xsimd#986). This is already done in nixpkgs in #272992, but it's not available yet inmaster(it's instaging). Combined with this, thescipybuilds successfully on i686.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.