[Backport staging-23.11] auto-patchelf: add support for __structuredAttrs#275923
Merged
symphorien merged 3 commits intostaging-23.11from Jan 6, 2024
Merged
[Backport staging-23.11] auto-patchelf: add support for __structuredAttrs#275923symphorien merged 3 commits intostaging-23.11from
symphorien merged 3 commits intostaging-23.11from
Conversation
(cherry picked from commit 9faad7f)
(cherry picked from commit 45901c4)
This commit adds a test for the newly added support for __structuredAttrs in autoPatchelf(hook). It copied a reasonably small-closure binary derivation that makes use of autoPatchelf, stripped it down for the purpose of the test, and check that autoPatchelf correctly set the interpreter and runpath whether __structuredAttrs is set to true or not. (cherry picked from commit 00d0418)
13 tasks
ofborg
bot
added
8.has: package (new)
symphorien
requested changes
Dec 23, 2023
Member
symphorien
left a comment
symphorien
left a comment
There was a problem hiding this comment.
Backporting something that has a deprecation warning seems wrong
Member
|
I'm pretty sure that deprecation was only moved around in code, nothing new is deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
staging-23.11, triggered by a label in #272752.